Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup build on qt6 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixup build on qt6 #6

wants to merge 1 commit into from

Conversation

neochapay
Copy link

No description provided.

@jmlich jmlich mentioned this pull request Aug 8, 2023
Closed
attah
attah reviewed Aug 9, 2023
View reviewed changes
src/daemon/daemon.pro
@@ -5,7 +5,7 @@ QT -= gui
QT += dbus

CONFIG += \
c++11 \
c++17 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least when i make apps for SFOS, their Qt version does not recognize c++17 as CONFIG, so i had to resort to QMAKE_CXXFLAGS += -std=c++17.
(And c++11 maps to -std=gnu++0x)

mlehtima
mlehtima reviewed Aug 9, 2023
View reviewed changes
src/plugin/plugin.cpp
@@ -75,7 +75,7 @@ class Q_DECL_EXPORT NemoDeviceLockPlugin : public QQmlExtensionPlugin
qDBusRegisterMetaType<NemoDeviceLock::Fingerprint>();
qDBusRegisterMetaType<QVector<NemoDeviceLock::Fingerprint>>();

qmlRegisterType<NemoDeviceLock::FingerprintModel>();
// qmlRegisterType<NemoDeviceLock::FingerprintModel>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally disabled and will this cause issues?

pvuorela
pvuorela requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the finger print model doesn't look proper and the review comment unaddressed. Marking as needing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlehtima mlehtima mlehtima left review comments

@attah attah attah left review comments

@pvuorela pvuorela pvuorela requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neochapay @pvuorela @attah @mlehtima